umartin opened a new pull request, #651:
URL: https://github.com/apache/incubator-sedona/pull/651

   …omFromWKT/WKB/Text.
   
   The previous commit was a bit to lax when checking input types.
   Any input that's not recognized would return null. Now null is explicitly 
checked.
   
   
   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor 
Rules](https://sedona.apache.org/community/rule/) and [Contributor Development 
Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is 
https://issues.apache.org/jira/browse/SEDONA-127. The PR name follows the 
format `[SEDONA-127] my subject`.
   
   
   ## What changes were proposed in this PR?
   
   This is a follow up on SEDONA-127 (merged but not released).
   The previous commit introduced null safety but accidentally allowed wrong 
input types to be treated as null.
   E.g. ST_GeomFromText(0) should fail instead of returning null.
   
   ## How was this patch tested?
   
   Tests added
   
   ## Did this PR include necessary documentation updates?
   
   - No, this PR does not affect any public API so no need to change the docs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to