jiayuasu commented on PR #647: URL: https://github.com/apache/incubator-sedona/pull/647#issuecomment-1193519962
@Kimahriman Yes, I think it will be good to make Sedona-common as a compile scope dependency to whatever package needs it. So the user no need to include it manually. As in this PR, sedona-core pom: `needs sedona-common`, as a compile scope dependency sedona-sql pom: `no update needed` because it needs sedona-core (provided scope) for spatial join and kyro serializer sedona-viz pom: `no update needed` because it needs sedona-core ans sedona-sql (provided scope) for spatial join and kyro serializer sedona-python-adapter pom: `no update needed` because it needs sedona-core and sedona-sql (compile scope) sedona-flink: `needs sedona-common` as a compile scope dependency. It currently also needs sedona-core and sedona-sql (provided scope). Note that: sedona-core and sedona-sql dependencies will eventually be dropped as we move all common functions to sedona-common in the next few PRs). Can you update the PR? Then I will merge this PR. Eventually I plan to release this PR to Sedona 1.3.0, not the next release 1.2.1. I think this PR is a rather big change to the project structure and is better not put in a maintenance release like 1.2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
