sekikn commented on code in PR #653:
URL: https://github.com/apache/incubator-sedona/pull/653#discussion_r935084225


##########
core/pom.xml:
##########
@@ -41,9 +41,15 @@
         <dependency>
             <groupId>org.apache.hadoop</groupId>
             <artifactId>hadoop-minicluster</artifactId>
-            <version>2.7.4</version>
+            <version>${hadoop.version}</version>
             <scope>test</scope>
         </dependency>
+        <dependency>
+          <groupId>org.mockito</groupId>
+          <artifactId>mockito-all</artifactId>
+          <version>1.8.5</version>
+          <scope>compile</scope>

Review Comment:
   > Why did this need to be added as an additional dependency?
   
   Some versions of Hadoop 2.x (e.g., 2.10.2) doesn't have Mockito in the 
minicluster test-jar, and it leads to NoClassDefFoundError unless specifying 
this dependency explicitly. According to 
https://issues.apache.org/jira/browse/HADOOP-14857, it's supposed to be fixed 
in 3.x, but 3.2.4 still seems to have the same problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to