Kimahriman commented on code in PR #662:
URL: https://github.com/apache/incubator-sedona/pull/662#discussion_r946638358
##########
flink/src/main/java/org/apache/sedona/flink/Catalog.java:
##########
@@ -32,6 +32,9 @@ public static UserDefinedFunction[] getFuncs() {
new Constructors.ST_GeomFromGeoJSON(),
new Constructors.ST_GeomFromGeoHash(),
new Functions.ST_Buffer(),
+ new Functions.ST_MakeValid(),
+ new Functions.ST_Intersection(),
+ new Functions.ST_Difference(),
Review Comment:
Can you just make a separate PR for these and add them to the new common
module created in https://github.com/apache/incubator-sedona/pull/647? Even
though they're pretty simple it will help not to maintain both definitions in
flink and spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
