Kontinuation opened a new pull request, #704: URL: https://github.com/apache/incubator-sedona/pull/704
## Did you read the Contributor Guide? - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/) ## Is this PR related to a JIRA ticket? - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-180. ## What changes were proposed in this PR? This patch makes ST_* functions foldable, and declared input types for these functions to make the SQL analyzer perform type checking for these ST_* function calls and emit more friendly error messages. Raster functions and viz functions are still left unchanged. I've deliberately left `ST_Binary` and `ST_AsEWKB` unfoldable since unit tests would fail after making these expressions foldable. The reason is that folding binary expressions as constants triggers a function call to [`encodeHexString(byte[], boolean)`](https://commons.apache.org/proper/commons-codec/apidocs/org/apache/commons/codec/binary/Hex.html#encodeHexString-byte:A-boolean-) in spark-sql, while the bundled Apache commons-codec of sernetcdf jar do not have this function defined. We may have to release a new version of sernetcdf with a newer version of / without commons-codec bundled. I've also moved some implementations of ST functions to `sedona-common`, so that they can be reused by other distributed computation engines. ## How was this patch tested? Hopefully existing unit tests are sufficient to guarantee that I'm not breaking anything. ## Did this PR include necessary documentation updates? - No, this PR does not affect any public API so no need to change the docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
