awadhesh14 commented on code in PR #737: URL: https://github.com/apache/incubator-sedona/pull/737#discussion_r1051539051
########## python/tests/sql/test_function.py: ########## @@ -50,6 +50,22 @@ class TestPredicateJoin(TestBase): ] ) + def test_st_concave_hull(self): + polygon_wkt_df = self.spark.read.format("csv"). \ + option("delimiter", "\t"). \ + option("header", "false"). \ + load(mixed_wkt_geometry_input_location) + + polygon_wkt_df.createOrReplaceTempView("polygontable") + polygon_wkt_df.show() + + polygon_df = self.spark.sql("select ST_GeomFromWKT(polygontable._c0) as countyshape from polygontable") + polygon_df.createOrReplaceTempView("polygondf") + polygon_df.show() + + function_df = self.spark.sql("select ST_ConcaveHull(polygondf.countyshape, 1.0) from polygondf") + function_df.show() Review Comment: @jiayuasu This file follows the pattern of `show` type of tests only(reference is to all other tests in this file). The assert tests have been added to the test files following that pattern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org