jiayuasu commented on code in PR #735:
URL: https://github.com/apache/incubator-sedona/pull/735#discussion_r1059789647
##########
pom.xml:
##########
@@ -59,178 +59,198 @@
<properties>
<project.scm.id>github</project.scm.id>
- <geotools.version>24.0</geotools.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
- <dependency.scope>provided</dependency.scope>
+ <java.version>1.8</java.version>
+ <maven.compiler.source>${java.version}</maven.compiler.source>
+ <maven.compiler.target>${java.version}</maven.compiler.target>
+ <maven.deploy.skip>false</maven.deploy.skip>
+ <maven.compiler.plugin.version>3.10.1</maven.compiler.plugin.version>
+
+ <cdm.version>5.4.2</cdm.version>
+ <geotools.version>24.0</geotools.version>
+ <hadoop.version>3.2.4</hadoop.version>
+ <jackson.version>2.13.4</jackson.version>
<jts.version>1.19.0</jts.version>
<jts2geojson.version>0.16.1</jts2geojson.version>
- <netcdf.version>5.4.2</netcdf.version>
<spark.version>3.3.0</spark.version>
<spark.compat.version>3.0</spark.compat.version>
- <sedona.jackson.version>2.13.3</sedona.jackson.version>
- <hadoop.version>3.2.4</hadoop.version>
- <maven.deploy.skip>false</maven.deploy.skip>
- <maven.compiler.plugin.version>3.10.1</maven.compiler.plugin.version>
+
<!-- Actual scala version will be set by a profile.
Setting a default value helps IDE:s that can't make sense of profiles.
-->
<scala.compat.version>2.12</scala.compat.version>
+
+ <geotools.scope>provided</geotools.scope>
+ <!-- Because it's not in Maven central, make it provided by default -->
+ <cdm.scope>provided</cdm.scope>
</properties>
<dependencies>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-databind</artifactId>
- <version>${sedona.jackson.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>jackson-core</artifactId>
- <version>${sedona.jackson.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>org.wololo</groupId>
- <artifactId>jts2geojson</artifactId>
- <version>${jts2geojson.version}</version>
- <exclusions>
- <exclusion>
- <groupId>org.locationtech.jts</groupId>
- <artifactId>jts-core</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>org.locationtech.jts</groupId>
- <artifactId>jts-core</artifactId>
- <version>${jts.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>hadoop-client</artifactId>
- <version>${hadoop.version}</version>
- <scope>${dependency.scope}</scope>
- <exclusions>
- <exclusion>
- <groupId>log4j</groupId>
- <artifactId>log4j</artifactId>
- </exclusion>
- <exclusion>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-log4j12</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>edu.ucar</groupId>
- <artifactId>cdm-core</artifactId>
- <version>${netcdf.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <!--The following GeoTools dependencies use GNU Lesser General Public
License and thus are excluded from the binary distribution-->
- <!-- Users have to include them by themselves manually -->
- <!-- See https://www.apache.org/legal/resolved.html#category-x -->
- <!-- See https://github.com/geotools/geotools#license -->
- <!--for CRS transformation-->
- <dependency>
- <groupId>org.geotools</groupId>
- <artifactId>gt-main</artifactId>
- <version>${geotools.version}</version>
- <scope>${dependency.scope}</scope>
- <exclusions>
- <exclusion>
- <groupId>org.locationtech.jts</groupId>
- <artifactId>jts-core</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <!--for CRS transformation-->
- <dependency>
- <groupId>org.geotools</groupId>
- <artifactId>gt-referencing</artifactId>
- <version>${geotools.version}</version>
- <scope>${dependency.scope}</scope>
- <exclusions>
- <exclusion>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <!--for CRS transformation-->
- <dependency>
- <groupId>org.geotools</groupId>
- <artifactId>gt-epsg-hsql</artifactId>
- <version>${geotools.version}</version>
- <scope>${dependency.scope}</scope>
- <exclusions>
- <exclusion>
- <groupId>com.fasterxml.jackson.core</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <!--for GeoTiff Reader-->
- <dependency>
- <groupId>org.geotools</groupId>
- <artifactId>gt-geotiff</artifactId>
- <version>${geotools.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>org.geotools</groupId>
- <artifactId>gt-coverage</artifactId>
- <version>${geotools.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-core_${scala.compat.version}</artifactId>
- <version>${spark.version}</version>
- <scope>${dependency.scope}</scope>
- <exclusions>
- <exclusion>
- <groupId>org.apache.hadoop</groupId>
- <artifactId>*</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
- <dependency>
- <groupId>org.apache.spark</groupId>
- <artifactId>spark-sql_${scala.compat.version}</artifactId>
- <version>${spark.version}</version>
- <scope>${dependency.scope}</scope>
- </dependency>
- <!-- Test -->
+ <!-- Include junit automatically, projects must include scalatest
themselves since not all use -->
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
- <version>4.13.1</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.scalatest</groupId>
- <artifactId>scalatest_${scala.compat.version}</artifactId>
- <version>3.1.1</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-compiler</artifactId>
- <version>${scala.version}</version>
- <scope>test</scope>
</dependency>
</dependencies>
+
+ <dependencyManagement>
+ <dependencies>
+ <dependency>
+ <groupId>org.wololo</groupId>
+ <artifactId>jts2geojson</artifactId>
+ <version>${jts2geojson.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.locationtech.jts</groupId>
+ <artifactId>jts-core</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.locationtech.jts</groupId>
+ <artifactId>jts-core</artifactId>
+ <version>${jts.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>edu.ucar</groupId>
+ <artifactId>cdm-core</artifactId>
+ <version>${cdm.version}</version>
+ <scope>${cdm.scope}</scope>
+ </dependency>
+ <!--The following GeoTools dependencies use GNU Lesser General
Public License and thus are excluded from the binary distribution-->
+ <!-- Users have to include them by themselves manually -->
+ <!-- See https://www.apache.org/legal/resolved.html#category-x -->
+ <!-- See https://github.com/geotools/geotools#license -->
+ <!--for CRS transformation-->
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-main</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>org.locationtech.jts</groupId>
+ <artifactId>jts-core</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!--for CRS transformation-->
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-referencing</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!--for CRS transformation-->
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-epsg-hsql</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-shapefile</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>com.fasterxml.jackson.core</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <!--for GeoTiff Reader-->
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-geotiff</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.geotools</groupId>
+ <artifactId>gt-coverage</artifactId>
+ <version>${geotools.version}</version>
+ <scope>${geotools.scope}</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-core_${scala.compat.version}</artifactId>
+ <version>${spark.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.spark</groupId>
+ <artifactId>spark-sql_${scala.compat.version}</artifactId>
+ <version>${spark.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-client</artifactId>
+ <version>${hadoop.version}</version>
+ <scope>provided</scope>
+ <exclusions>
+ <exclusion>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
+ <dependency>
+ <groupId>commons-lang</groupId>
+ <artifactId>commons-lang</artifactId>
+ <version>2.6</version>
+ </dependency>
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-library</artifactId>
+ <version>${scala.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-compiler</artifactId>
+ <version>${scala.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.scala-lang.modules</groupId>
+
<artifactId>scala-collection-compat_${scala.compat.version}</artifactId>
+ <version>2.5.0</version>
+ </dependency>
+
+ <dependency>
+ <groupId>junit</groupId>
+ <artifactId>junit</artifactId>
+ <version>4.13.1</version>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scalatest</groupId>
+ <artifactId>scalatest_${scala.compat.version}</artifactId>
+ <version>3.1.1</version>
+ <scope>test</scope>
+ </dependency>
+ </dependencies>
+ </dependencyManagement>
<repositories>
<repository>
<id>maven2-repository.dev.java.net</id>
Review Comment:
One last piece: I think java.net repo is no longer needed, right? I think it
was used by some geotools dependencies. But now, after I remove this repo, the
compilation still works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
