[
https://issues.apache.org/jira/browse/SEDONA-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17696202#comment-17696202
]
Gregoire Leleu commented on SEDONA-248:
---------------------------------------
Currently, the tests are failing because the workflow is still using common +
core + sql + viz but I removed jts-core, so it's not available. It works on my
computer because I'm using spark-shaded.
I would need help updating the tests because they can't find the spark-shaded
jar. The code to find the jars (below) fails because there is no
resolved-pom.xml for shaded. Can't we just grab all the files called "*.jar" in
the folders?
{code:java}
sedona_jar_files () {
local subdir
for subdir in 'spark-shaded' 'viz'; do
local artifact_id="$(
mvn \
org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate \
-Dexpression=project.artifactId \
-q \
-DforceStdout \
-f "${subdir}"/target/resolved-pom.xml
)"
local artifact_version="$(
mvn \
org.apache.maven.plugins:maven-help-plugin:3.2.0:evaluate \
-Dexpression=project.version \
-q \
-DforceStdout \
-f "${subdir}"/target/resolved-pom.xml
)"
echo "$(pwd)/${subdir}/target/${artifact_id}-${artifact_version}.jar"
done
}
export SEDONA_JAR_FILES="$(sedona_jar_files | paste -sd':')" {code}
Also, more generally does that mean that if we only put core + sql + viz +
geotools-wrapper + cdm-core, we'll run in the same issue? Do we need to bring
back the others? (jts-core in particular)
> R – Let dev version of R package use SNAPSHOT jars
> --------------------------------------------------
>
> Key: SEDONA-248
> URL: https://issues.apache.org/jira/browse/SEDONA-248
> Project: Apache Sedona
> Issue Type: Improvement
> Reporter: Gregoire Leleu
> Priority: Major
> Attachments: image-2023-02-17-11-45-38-710.png
>
>
> Currently, one source of error is that the dev version of the R package calls
> the Sedona jars from the previous release. Right now the dev version (1.4.0)
> by default calls the 1.3.1 jars.
> You can override it, but you either need to build the jars yourself (most R
> users won't do it) or get them somewhere (but where?).
> Would it be possible to:
> * Make the jars available in a maven repo (I would have assumed
> [https://repository.apache.org/content/groups/snapshots/org/apache/sedona/sedona-core-3.0_2.13/]
> from the documentation, but 1.4.0 isn't there)
> * Have the dev version point to those jars
> * Change to the regular repo for the release
> In terms of cache: will the jar cache system update the Sedona SNAPSHOT jars
> if the name doesn't change?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
