jiayuasu commented on code in PR #850: URL: https://github.com/apache/sedona/pull/850#discussion_r1220411187
########## python/sedona/core/geom/envelope.py: ########## Review Comment: Please separate the actual code change and doc change to two separate PRs since they are not related. For changes in Python code, you need to create a JIRA ticket first: https://issues.apache.org/jira/projects/SEDONA If you don't have a Sedona JIRA account, please sign up for one. ########## docs/setup/compile.md: ########## @@ -94,7 +97,8 @@ pipenv --python 3.7 5. Install the PySpark version and other dependency ``` cd python -pipenv install pyspark==3.0.1 +pipenv install pyspark +pipenv install shapely~=1.7 Review Comment: Why is Shapely needed here? Why not `pipenv install` since shapely is already listed here: https://github.com/apache/sedona/blob/master/python/Pipfile#L14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
