jiayuasu commented on code in PR #863:
URL: https://github.com/apache/sedona/pull/863#discussion_r1234757985
##########
common/src/main/java/org/apache/sedona/common/Functions.java:
##########
@@ -931,4 +931,34 @@ public static Geometry geometricMedian(Geometry geometry)
throws Exception {
return geometricMedian(geometry, DEFAULT_TOLERANCE, DEFAULT_MAX_ITER,
false);
}
+ public static Geometry boundingDiagonal(Geometry geometry) {
+ if (geometry.isEmpty()) {
+ return GEOMETRY_FACTORY.createLineString();
+ }else {
+ Envelope envelope = geometry.getEnvelopeInternal();
Review Comment:
getEnvelopeInternal() also traverses all coordinates I guess. Why not just
have a single loop and traverse all coordinates?
##########
sql/common/src/main/scala/org/apache/sedona/sql/UDF/Catalog.scala:
##########
@@ -178,14 +179,10 @@ object Catalog {
function[RS_Array](),
function[RS_Normalize](),
function[RS_Append](),
- function[RS_AddBandFromArray](),
Review Comment:
Why remove other functions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
