jiayuasu commented on code in PR #889:
URL: https://github.com/apache/sedona/pull/889#discussion_r1260031728
##########
sql/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/st_functions.scala:
##########
@@ -380,5 +380,9 @@ object st_functions extends DataFrameAPI {
def ST_HausdorffDistance(g1: String, g2: String, densityFrac: Double) =
wrapExpression[ST_HausdorffDistance](g1, g2, densityFrac);
+ def ST_CoordDim(geometry: Column): Column =
wrapExpression[ST_CoordDim](geometry)
Review Comment:
Please read
[dataFrameAPITestScala.scala](https://github.com/apache/sedona/commit/b6702d1adacb98d83cc470e9b24877ab7785cdf8#diff-1346635eec60a5a0caf33a991414d06123a07299cb24d059af6424b88b1d3bfd)
##########
python/sedona/sql/st_functions.py:
##########
@@ -1422,3 +1423,14 @@ def ST_HausdorffDistance(g1: ColumnOrName, g2:
ColumnOrName, densityFrac: Option
args = (g1, g2, densityFrac)
return _call_st_function("ST_HausdorffDistance", args)
+@validate_argument_types
+def ST_CoordDim(geometry: ColumnOrName) -> Column:
Review Comment:
This function is not tested. Please read the `test_dataframe_api.py` in this
PR:
https://github.com/apache/sedona/commit/b6702d1adacb98d83cc470e9b24877ab7785cdf8#diff-ab6aae6fd177bcb406674e400a6370cf621d76c5d2de30678a3d521bb9b5a5cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
