Hi Rob, Thanks for your feedback, my responses are inline On Fri, Feb 23, 2018 at 7:39 AM, < [email protected]> wrote:
> > From: Rob Foley <[email protected]> > To: [email protected] > Cc: > Bcc: > Date: Wed, 21 Feb 2018 10:18:46 -0500 > Subject: Re: Should UserALE.js build directory reside in SCM? > I'm not entirely sure what you are referring to when you say "this > directory". If you mean the build directory, Yes I do. Thank you for making this explicit. > I think it'd be useful for > people to have that available, otherwise they'd have to build from source > any time they pull from npm, which is fairly atypical. I agree. This is a post-VOTE step in the release procedure so we can address it if and when we get feedback from the Incubator PMC. > I'd be open to > arguments about that though. Usually, the "package.json" file specifies a > "main" file which is to be considered the entry point when being imported > externally. We should change this to be built file. > > Can you please open a JIRA issue for the above? As this is the first UserALE,js Incubating release it would be good to iron all these things out so we can easily spin up future releases. Thanks Lewis
