----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22120/#review44512 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java <https://reviews.apache.org/r/22120/#comment78916> This is override the method in base class which return Context. Update the two constructors to be in sync. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java <https://reviews.apache.org/r/22120/#comment78917> Fixed sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java <https://reviews.apache.org/r/22120/#comment78918> yes, removed. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java <https://reviews.apache.org/r/22120/#comment78919> Done sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java <https://reviews.apache.org/r/22120/#comment78921> Removed sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java <https://reviews.apache.org/r/22120/#comment78923> Updated - Prasad Mujumdar On May 31, 2014, 10:13 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22120/ > ----------------------------------------------------------- > > (Updated May 31, 2014, 10:13 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-241 > https://issues.apache.org/jira/browse/SENTRY-241 > > > Repository: sentry > > > Description > ------- > > The Hive binding grantRevokeTask should fire the Sentry on-failure hook if > configured. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > f1e6247 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > f8c694c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java > c6f1ce2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/DummySentryOnFailureHook.java > e4055a7 > > Diff: https://reviews.apache.org/r/22120/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Prasad Mujumdar > >
