> On June 2, 2014, 4:54 p.m., Prasad Mujumdar wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java,
> >  line 222
> > <https://reviews.apache.org/r/22105/diff/1/?file=600626#file600626line222>
> >
> >     Are we removing this additional error checking ?

This error checking is handled in analyzePrivilegeObject().


- Sravya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22105/#review44506
-----------------------------------------------------------


On May 31, 2014, 2:36 a.m., Sravya Tirukkovalur wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22105/
> -----------------------------------------------------------
> 
> (Updated May 31, 2014, 2:36 a.m.)
> 
> 
> Review request for sentry, Arun Suresh and Prasad Mujumdar.
> 
> 
> Bugs: SENTRY-215
>     https://issues.apache.org/jira/browse/SENTRY-215
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Support SHOW GRANT ROLE xxx ON [SERVER, DATABASE, TABLE, URI] xxx
> 
> 
> Diffs
> -----
> 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
>  1012605e4d09074851704ecf9df4e4a613cd919d 
>   
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java
>  6d890411e5968bd6dd7e3f489bdf08d9842547d9 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java
>  50aadb868276f88ea6c36e23d83d118ca7205c44 
> 
> Diff: https://reviews.apache.org/r/22105/diff/
> 
> 
> Testing
> -------
> 
> Added new integration tests
> 
> 
> Thanks,
> 
> Sravya Tirukkovalur
> 
>

Reply via email to