> On March 22, 2016, 6:12 a.m., Dapeng Sun wrote: > > Thank Colin, I left some comments, it seems some class would not be used, I > > think we need add some comments or annotations for them and file a jira to > > cleanup these classes.
You're right, I'll file another JIRA to cleanup unnecessary classes. > On March 22, 2016, 6:12 a.m., Dapeng Sun wrote: > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java, > > line 135 > > <https://reviews.apache.org/r/45023/diff/1/?file=1305064#file1305064line135> > > > > Is there any test for case sensitive JIRA SENTRY-1103 is responsible for this, I'll add the test cases in that JIRA. > On March 22, 2016, 6:12 a.m., Dapeng Sun wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java, > > line 210 > > <https://reviews.apache.org/r/45023/diff/1/?file=1305049#file1305049line210> > > > > We may no need to set default value per the previous behaviour. Ok. > On March 22, 2016, 6:12 a.m., Dapeng Sun wrote: > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPrivilege.java, > > line 67 > > <https://reviews.apache.org/r/45023/diff/1/?file=1305066#file1305066line67> > > > > It seems **DBWildcardPrivilege** will not be used, we should add some > > tag like annotations or comments for it For such class I'll add the comments with todo to describe it should be removed in the next step. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45023/#review124733 ----------------------------------------------------------- On March 18, 2016, 8:43 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45023/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 8:43 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Refactor ResourceAuthorizationProvider with CommonPrivilege and CommonPolicy. > The interface Privilege will be updated from *boolean implies(Privilege p)* > to *boolean implies(Privilege p, Model model)* > > > Diffs > ----- > > pom.xml 2f855fb > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java > e093b5c > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > 6b79dda > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/policy/hive/TestResourceAuthorizationProviderGeneralCases.java > 05dc449 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/policy/hive/TestResourceAuthorizationProviderSpecialCases.java > bf57bf2 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/privilege/hive/TestCommonPrivilegeForHive.java > 28674bd > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java > ea14d44 > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/conf/SolrAuthzConf.java > 227f75e > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/policy/solr/TestSearchAuthorizationProviderGeneralCases.java > f460d7a > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/policy/solr/TestSearchAuthorizationProviderSpecialCases.java > 6d51dee > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/privilege/solr/TestCommonPrivilegeForSearch.java > 644e0ef > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopAuthBinding.java > 55d9eb9 > > sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/conf/SqoopAuthConf.java > 097e7f7 > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java > b01b88f > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java > 99eaf18 > > sentry-binding/sentry-binding-sqoop/src/test/java/org/apache/sentry/privilege/sqoop/TestCommonPrivilegeForSqoop.java > 0ec7783 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/CommonPrivilege.java > 43cb5c8 > > sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/Privilege.java > 27d5afa > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPrivilege.java > 69e9ad2 > > sentry-policy/sentry-policy-engine/src/main/java/org/apache/sentry/policy/engine/common/CommonPolicyEngine.java > a661190 > > sentry-policy/sentry-policy-indexer/src/main/java/org/apache/sentry/policy/indexer/IndexerWildcardPrivilege.java > cda5d3d > > sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestCommonPrivilegeForIndexer.java > 42fed4b > > sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderGeneralCases.java > 2781bf9 > > sentry-policy/sentry-policy-indexer/src/test/java/org/apache/sentry/policy/indexer/TestIndexerAuthorizationProviderSpecialCases.java > 3af9481 > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SearchWildcardPrivilege.java > 8aeab04 > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java > ae70943 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/HadoopGroupResourceAuthorizationProvider.java > bcd3312 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 758f2cf > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/file/HadoopGroupResourceAuthorizationProvider.java > 8674700 > > sentry-provider/sentry-provider-common/src/test/java/org/apache/sentry/provider/common/TestGetGroupMapping.java > dfb5d70 > sentry-provider/sentry-provider-db/pom.xml 38e0924 > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/LocalGroupResourceAuthorizationProvider.java > 489daf4 > > Diff: https://reviews.apache.org/r/45023/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
