----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34079/#review126520 -----------------------------------------------------------
Thank Colin for your contribution, I left some comments. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1117) <https://reviews.apache.org/r/34079/#comment189540> We don't need the change here. Seems if group is null, we still need to call the jdo query, how about update code to reduce creating unused role set. ```` Set<String> roles = null; if (group is not null) { execute query.. } else { roles = Sets.newHashSet() } sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1293) <https://reviews.apache.org/r/34079/#comment189544> yes, we should check `users != null` before `openTransaction()` sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1397) <https://reviews.apache.org/r/34079/#comment189549> Should check if group or user is null or empty here. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 1835) <https://reviews.apache.org/r/34079/#comment189552> `getMSentryPrivileges` called `openTransaction()`, it is better to share a pm at one method call. - Dapeng Sun On 五月 12, 2015, 2:54 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34079/ > ----------------------------------------------------------- > > (Updated 五月 12, 2015, 2:54 p.m.) > > > Review request for sentry, Dapeng Sun, shen guoquan, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Update jdo model for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > 0076753 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUser.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > d8f69b5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7937d0 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 35319db > > Diff: https://reviews.apache.org/r/34079/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
