Named filter is difficult to understand and the “named” has different implications.
If you want to support (either now or in the future) more flexible filtering such as wildcard, I suggest to use the name like objectFilter. But if you don’t want to support wildcard and only allow one object path, use objectName or objectPath. Thanks, Haifeng From: Colin Ma [mailto:[email protected]] On Behalf Of Colin Ma Sent: Tuesday, April 5, 2016 2:03 PM To: Chen, Haifeng <[email protected]>; Ma, Junjie <[email protected]>; sentry <[email protected]> Subject: Re: Review Request 45728: SENTRY-1176: Update thrift API for export with specific auth object This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45728/ On April 5th, 2016, 5:45 a.m. UTC, Jerry Chen wrote: sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift<https://reviews.apache.org/r/45728/diff/1/?file=1325581#file1325581line244> (Diff revision 1) 244 3: optional string authObjectFilter # filter for specific auth object My oppinion authObjectFilter is not quite a good name here. Naming suggestions: objectName objectPath how about named filter? - Colin On April 5th, 2016, 3:53 a.m. UTC, Colin Ma wrote: Review request for sentry. By Colin Ma. Updated April 5, 2016, 3:53 a.m. Repository: sentry Description Update thrift API for export with specific auth object Diffs * sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java (8145252) * sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift (40889e8) View Diff<https://reviews.apache.org/r/45728/diff/>
