> On 四月 7, 2016, 5:44 a.m., Jerry Chen wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForHaWithoutKerberos.java, > > line 107 > > <https://reviews.apache.org/r/34086/diff/3/?file=1327605#file1327605line107> > > > > Use null instead of new HashSet<String>(). The same for the following > > instances. > > > > One question to consider: Is the original version of > > listPrivilegesForProvider without users parameters still be meaningful? > > > > If the answer is YES, then we can add an overload version with users > > instead of directly changing the original one with users parameter.
Thank Jerry for your comments, I have update all the set with using ADMIN_USER to construct the userNames. `Is the original version of listPrivilegesForProvider without users parameters still be meaningful?` I think it won't meaningful. `listPrivilegesForProvider` is only used for `SimpleDBProviderBackend`, the provider have been updated with added users parameters. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34086/#review127555 ----------------------------------------------------------- On 四月 6, 2016, 2:56 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34086/ > ----------------------------------------------------------- > > (Updated 四月 6, 2016, 2:56 p.m.) > > > Review request for sentry, Dapeng Sun and Jerry Chen. > > > Repository: sentry > > > Description > ------- > > Update SentryPolicyStoreProcessor for grant user to role > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > de50adb > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > edc5661 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 8881d82 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForHaWithoutKerberos.java > ac4df77 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java > 0792eb6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 07c7f7a > > Diff: https://reviews.apache.org/r/34086/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
