----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45790/#review127986 -----------------------------------------------------------
Ship it! Thanks for the change Hao! - Sravya Tirukkovalur On April 6, 2016, 1:14 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45790/ > ----------------------------------------------------------- > > (Updated April 6, 2016, 1:14 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Ensure AccessURI work with S3. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-common/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHookBase.java > 6df939f9ea90179e325fe2a304db2a77035b1d44 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestURI.java > c7ac070f8097c5482d6e5ed9dd94f60f8dd63508 > > sentry-core/sentry-core-model-db/src/test/java/org/apache/sentry/core/db/TestURI.java > b639a9543c88e3cd1a97b333abf3e573c20fab51 > > Diff: https://reviews.apache.org/r/45790/diff/ > > > Testing > ------- > > Added test cases testS3URIWithoutPrefix, testS3UriWithAuthority and testS3Uri. > > > Thanks, > > Hao Hao > >