> On April 14, 2016, 5:34 a.m., Hao Hao wrote: > > sentry-policy/sentry-policy-kafka/src/main/java/org/apache/sentry/policy/kafka/KafkaWildcardPrivilege.java, > > line 124 > > <https://reviews.apache.org/r/46177/diff/1/?file=1343592#file1343592line124> > > > > Action is case insensitive?
Yes, and I happened to find this issue while doing demo of it. > On April 14, 2016, 5:34 a.m., Hao Hao wrote: > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java, > > line 141 > > <https://reviews.apache.org/r/46177/diff/1/?file=1343589#file1343589line141> > > > > should we throw exceptions here when keytabprop is null? I notice > > principalProp can be coming from getServerPrincipal from actualHost. But > > keytabprop seems just coming from the config. I think if we do not throw exception, it will eventually fail complaining connection to sentry server failed due to kerberos negotiaition failure. May be we can just add some debug msgs. > On April 14, 2016, 5:34 a.m., Hao Hao wrote: > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java, > > line 546 > > <https://reviews.apache.org/r/46177/diff/1/?file=1343589#file1343589line546> > > > > Should we throw the exception with the used principal and keytab here? Makes sense, adding it. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46177/#review128837 ----------------------------------------------------------- On April 13, 2016, 10:42 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46177/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 10:42 p.m.) > > > Review request for sentry, Dapeng Sun and Hao Hao. > > > Bugs: SENTRY-1188 > https://issues.apache.org/jira/browse/SENTRY-1188 > > > Repository: sentry > > > Description > ------- > > Fixes to get kerberos auth work. > > > Diffs > ----- > > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java > 3bce6cc40d2236429af0b3308d6a80fbe6ff9656 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java > 8f4a8c48421cdc9116ef19bc14e5f650983d3f82 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java > a0007a3e346cf17107add362fcd8166b77ac1304 > > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java > e0d767ec3db0c678eda3b5f929910651cd936fba > > sentry-policy/sentry-policy-kafka/src/main/java/org/apache/sentry/policy/kafka/KafkaWildcardPrivilege.java > bc299b02e2f52f80066498c894bc96b491051a6a > > Diff: https://reviews.apache.org/r/46177/diff/ > > > Testing > ------- > > Tested by deploying the bits on a real cluster. > > > Thanks, > > Ashish Singh > >
