> On April 11, 2016, 12:51 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java, > > line 33 > > <https://reviews.apache.org/r/45329/diff/1/?file=1314493#file1314493line33> > > > > Does it mean that the end user will not use SentryShellKafka? > > Ashish Singh wrote: > Hao, that is a good question. Kafka right now does not have a way to > allow users to perform acls crud on just a topic or consumer group. As of > now, this tool is limited to be used by admins, however this is very likely > to be changed in upcoming Kafka releases. Once that happens in Kafka > community, we can update this tool as well.
Thanks for the answer. Looks good to me now. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45329/#review128053 ----------------------------------------------------------- On March 25, 2016, 1:13 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45329/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 1:13 a.m.) > > > Review request for sentry, Dapeng Sun and Hao Hao. > > > Bugs: SENTRY-1162 > https://issues.apache.org/jira/browse/SENTRY-1162 > > > Repository: sentry > > > Description > ------- > > SENTRY-1162: Add shell for Sentry Kafka integration > > > Diffs > ----- > > sentry-provider/sentry-provider-db/pom.xml > bf4dfdc1de90b1018767e2a61bee970655f02682 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellKafka.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/45329/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ashish Singh > >
