Ashish, thanks for the comments, created SENTRY-1210 to improve the Shell part.
Best regards, Colin Ma(Ma Jun Jie) -----Original Message----- From: Ashish Singh [mailto:[email protected]] Sent: Thursday, April 21, 2016 6:40 AM To: [email protected] Subject: Re: Merge SENTRY-999 with master Colin, I have a general comment on Shell, since we have SentryShellCommon, I was thinking may be it will be valuable to make it easier for plugins to extend it. There is quite a bit of duplication there as well. You can take a look at the way Solr and Kafka are extending it, especially the converters, KafkaTSentryPrivilegeConvertor. I do not mean to say we have to do that as part of 999, but something we should probably track. On Wed, Apr 20, 2016 at 10:22 AM, Ashish Singh <[email protected]> wrote: > Thanks Colin! > > On Tue, Apr 19, 2016 at 6:06 PM, Ma, Junjie <[email protected]> wrote: > >> Hi Ashish, >> >> The link for the review board is https://reviews.apache.org/r/46367/, >> and I just add this link to SENTRY-999. >> For the step-by-step example, I plan to publish a document to our >> wiki page based on SENTRY-999, thanks for the comment. >> >> Best regards, >> >> Colin Ma(Ma Jun Jie) >> >> -----Original Message----- >> From: Ashish Singh [mailto:[email protected]] >> Sent: Tuesday, April 19, 2016 10:30 PM >> To: [email protected] >> Subject: Re: Merge SENTRY-999 with master >> >> Colin, >> >> Thanks for the awesome work, this will go a long way to ease out >> adding plugins/integrations. Would it be possible for you to create a RB for >> 999. >> I do understand that you have RBs for sub-tasks, however they are all >> resolved. It will be hard to review sub-tasks without going through >> them all, so I feel that one giant patch will be helpful for >> reviewing in this case. >> >> One general comment I have, does not have to be part of 999, a >> step-by-step example to add a plugin/ integration along with some >> details on why that step is required will be really helpful. >> >> >> On Tue, Apr 19, 2016 at 12:35 AM, Ma, Junjie <[email protected]> wrote: >> >> > Hi all, >> > >> > SENTRY-999 is about refactor the Sentry to integrate with external >> > components quickly, and the following changes are for this refactor: >> > >> > 1. CommonPolicyEngine will be the default PolicyEngine for all >> > components(include Hive, Solr, Sqoop, Kafka). >> > >> > 2. Add the PrivilegeModel which defines how to imply the >> resource >> > for specific component. >> > >> > 3. CommonPrivilege will be the default Privilege for all >> > components. >> > >> > 4. Using the ActionFactory for every component to imply the >> action >> > code. >> > 5. All bindings are updated with the CommonPolicyEngine. >> > >> > Please help to review the patch, and I'll merge SENTRY-999 with >> > master later, thanks. >> > >> > Best regards, >> > >> > Colin Ma(Ma Jun Jie) >> > >> > >> >> >> -- >> >> Regards, >> Ashish >> > > > > -- > > Regards, > Ashish > -- Regards, Ashish
