----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47084/ -----------------------------------------------------------
Review request for sentry and Vamsee Yarlagadda. Repository: sentry Description ------- >From working with this tool for a bit, I think the following additions would >be useful: 1) The tool warns/errors on cased role names being converted to lower case, but still prints the cased name in the log. For clarity these should also be lower cased. 2) When not importing, we should still print a message about what we would do, i.e. a dry-run message. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryConfigToolSolr.java 22895eb938f8c9092d68472038ddbf93534594f5 Diff: https://reviews.apache.org/r/47084/diff/ Testing ------- Manually tested, verified that the message is printed to the log. Thanks, Gregory Chanan
