----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47075/#review132383 -----------------------------------------------------------
Thank Ashish for your contribution! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java (line 53) <https://reviews.apache.org/r/47075/#comment196573> why not toLowerCase() ```` public String toLowerCase() { return toLowerCase(Locale.getDefault()); } sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java (line 54) <https://reviews.apache.org/r/47075/#comment196574> why not toLowerCase() sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java (line 55) <https://reviews.apache.org/r/47075/#comment196570> Do we need to test if we covered the case, likes "CLUSTER=kafka-cluster->HOST=*->action=write" which resource type is in front of HOST? - Dapeng Sun On 五月 7, 2016, 1:54 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47075/ > ----------------------------------------------------------- > > (Updated 五月 7, 2016, 1:54 a.m.) > > > Review request for sentry, Colin Ma and Dapeng Sun. > > > Bugs: SENTRY-1208 > https://issues.apache.org/jira/browse/SENTRY-1208 > > > Repository: sentry > > > Description > ------- > > SENTRY-1208: Make HOST implied in privileges if not specified explicitly. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/KafkaTSentryPrivilegeConvertor.java > af73755ae92ad4f61243d18b2521d144189532b4 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellKafka.java > d49bc57b5c0b619e5e0e34fcf1f2676535c9e13c > > Diff: https://reviews.apache.org/r/47075/diff/ > > > Testing > ------- > > Extended existing unit tests. > > > Thanks, > > Ashish Singh > >
