Thanks, Sravya. That seems very similar to the way I've seen feature branches work in Apache Hadoop.
Hadoop has an additional role called "branch committer." See https://hadoop.apache.org/bylaws.html and search for "branch committer." Basically, branch committers are authorized to make commits only to a specific git branch, not to any other branches. The goal of adding the branch committer role was to make feature development faster by allowing patches for a specific feature to be reviewed and committed by a larger group of people. Of course, new features are reviewed before merging to master. Sentry might want to think about adding a role like this, if it seems to make sense. best, ColinM On Thu, Jun 9, 2016, at 14:36, Sravya Tirukkovalur wrote: > Cool. > > @Colin: Let me explain how feature branches worked so far in the Sentry > community. And I would love to here what other communities do, and if we > can adopt some of the best practices. > - Committing: We create sub tasks and each sub task is reviewed as usual > and is committed by one of the committers after a +1 from committer. > - Merging: We ask the feature owner to rebase on master. And one of the > committers applies these commits on to the master. Or, we merge it with > master. > > Thanks, > > > > > On Thu, Jun 9, 2016 at 2:21 PM, Hao Hao <[email protected]> wrote: > > > +1 for having a feature branch. Thanks! > > > > Best, > > Hao > > > > On Thu, Jun 9, 2016 at 1:30 PM, Colin McCabe <[email protected]> wrote: > > > > > By the way, this is the first community I've been in that has two > > > Colins! > > > Hope it's not confusing :) > > > > > > > > > > > > > > > On Thu, Jun 9, 2016, at 13:29, Colin McCabe wrote: > > > > Thanks, Sravya. > > > > > > > > +1 for a feature branch, so that we don't have to worry about things > > > > like what release it should appear in until the feature is complete. > > > > > > > > I am interested in working on this feature, and I think Rahul Sharma is > > > > as well (both from Cloudera). If we decide to do a feature branch, I > > > > would be interested in being a branch committer and I believe Rahul > > > > would as well. > > > > > > > > cheers, > > > > Colin > > > > > > > > > > > > On Thu, Jun 9, 2016, at 12:21, Sravya Tirukkovalur wrote: > > > > > Hi folks, > > > > > > > > > > Shall we create a feature branch for Sentry HA redesign or do you all > > > > > feel > > > > > comfortable committing it to master? > > > > > > > > > > Thanks! > > > > > > > > > -- > Sravya Tirukkovalur
