> On June 15, 2016, 7:08 p.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java, > > line 47 > > <https://reviews.apache.org/r/48736/diff/1/?file=1420180#file1420180line47> > > > > Should we have another test with isHA to be true?
I have added a comment, that would enable more cases , once the HA functionality is implemented. There are many pieces of old code which check for haenabled, didnt want to hit them for this patch, > On June 15, 2016, 7:08 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java, > > line 1726 > > <https://reviews.apache.org/r/48736/diff/1/?file=1420181#file1420181line1726> > > > > Remove? Will remove it in the follow on jira :) - Rahul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48736/#review137803 ----------------------------------------------------------- On June 15, 2016, 5:10 p.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48736/ > ----------------------------------------------------------- > > (Updated June 15, 2016, 5:10 p.m.) > > > Review request for sentry, Anne Yu and Colin McCabe. > > > Repository: sentry > > > Description > ------- > > SENTRY-1319: Made changes as per Colin's comments. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryMetrics.java > c6d4d02fd77f4f9a31ea802c497fa23281bf7a75 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 578364933a3cdcf6c142b836360a83d322fe5c11 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceMetrics.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 1606b6d97c6696328906100eb10464fdc2fa19e8 > > Diff: https://reviews.apache.org/r/48736/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >
