----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49182/#review139361 -----------------------------------------------------------
Thank Colin for your review sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java (line 107) <https://reviews.apache.org/r/49182/#comment204571> Good suggestion. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java (line 55) <https://reviews.apache.org/r/49182/#comment204572> For URI privlege, its action could only be All, so we should specified it here. - Dapeng Sun On 六月 24, 2016, 1:46 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49182/ > ----------------------------------------------------------- > > (Updated 六月 24, 2016, 1:46 p.m.) > > > Review request for sentry and Colin Ma. > > > Bugs: SENTRY-1360 > https://issues.apache.org/jira/browse/SENTRY-1360 > > > Repository: sentry > > > Description > ------- > > For SentryClient, TSentryPrivilege should be the parameter for grant/revoke > privilege. it will be easy to extend Privilege. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 1e72b74 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > 1039e6e > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/CommandUtil.java > 2d2dcb5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantPrivilegeToRoleCmd.java > a1ef2f9 > > Diff: https://reviews.apache.org/r/49182/diff/ > > > Testing > ------- > > > Thanks, > > Dapeng Sun > >
