> On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 55 > > <https://reviews.apache.org/r/49392/diff/2-4/?file=1433181#file1433181line55> > > > > TODO for concurrent test cases?
https://issues.apache.org/jira/browse/SENTRY-1384 > On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 114 > > <https://reviews.apache.org/r/49392/diff/2-4/?file=1433181#file1433181line114> > > > > The location information is not available now or it will not available > > all the time? If the former, could you add a TODO here to check for the > > locaction info once it is available? It is not available now and we do not plan to make changes to DbNotificationListener. So, I do not think any TODO is required here? > On July 5, 2016, 6:47 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java, > > line 376 > > <https://reviews.apache.org/r/49392/diff/2-4/?file=1433181#file1433181line376> > > > > Will alter column also affects the location information? If so, we may > > want to add test cases for that as well? Alter column does not change the location. But thats a good point, we need to make sure we handle the "Alter tables" which do not trigger location changes also well, will check that in SENTRY-1321? - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49392/#review140845 ----------------------------------------------------------- On July 5, 2016, 6:22 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49392/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 6:22 p.m.) > > > Review request for sentry, Anne Yu, Colin McCabe, and Hao Hao. > > > Bugs: Sentry-1324 > https://issues.apache.org/jira/browse/Sentry-1324 > > > Repository: sentry > > > Description > ------- > > Add sentry specific test cases to use NotificationLog using > DbNotificationListener > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml > 02bfa49c9513a36a93017c706375bf58d063d7d7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 2add2d06ad1a54cf6746ac2e8d71ef3bc67899f7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > f1e6d75b2ae8e20343ff49bd46ef254ed6320ad4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestHMSNotificationLogUsingDBNotificationListener.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49392/diff/ > > > Testing > ------- > > All tests: new and regression pass. > > > Thanks, > > Sravya Tirukkovalur > >
