----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49976/#review142008 -----------------------------------------------------------
Better to refine TestGrantUserToRole like SENTRY-320 did. sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java (line 2022) <https://reviews.apache.org/r/49976/#comment207476> I think we can delete it - Dapeng Sun On 七月 13, 2016, 1:08 p.m., Ke Jia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49976/ > ----------------------------------------------------------- > > (Updated 七月 13, 2016, 1:08 p.m.) > > > Review request for sentry and Dapeng Sun. > > > Bugs: SENTRY-1401 > https://issues.apache.org/jira/browse/SENTRY-1401 > > > Repository: sentry > > > Description > ------- > > In V2, show role grant group groupname should not throw an exception if group > doesnt exist in db. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive-v2/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 0012a8a > > Diff: https://reviews.apache.org/r/49976/diff/ > > > Testing > ------- > > testing > > > Thanks, > > Ke Jia > >
