----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49683/#review143057 -----------------------------------------------------------
Thanks a lot Colin for this nice work! sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java (line 55) <https://reviews.apache.org/r/49683/#comment208759> Is it possible to make num of roles configurable? So we can also test with different range of roles. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java (line 68) <https://reviews.apache.org/r/49683/#comment208761> Could it be multi threads to make the creation faster sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java (line 103) <https://reviews.apache.org/r/49683/#comment208762> Add test for select queries? - Hao Hao On July 6, 2016, 2:39 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49683/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 2:39 a.m.) > > > Review request for sentry and Hao Hao. > > > Bugs: sentry-1347 > https://issues.apache.org/jira/browse/sentry-1347 > > > Repository: sentry > > > Description > ------- > > To test the performance of SENTRY-1290, the test for show table should be > created. The test case should include a lot of tables(eg, 5000 tables) and > the user should have a lot of privileges(eg, 5000 privileges). > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml 02bfa49 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerformanceManually.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49683/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
