----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50404/#review143423 -----------------------------------------------------------
Awesome work Rahul! Left minor comments. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java (line 89) <https://reviews.apache.org/r/50404/#comment209206> Add @VisibleForTesting annotation, so that the intent of this public method is clear? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java (line 140) <https://reviews.apache.org/r/50404/#comment209207> It is not clear to me what is the intent of close versus becomeStandby? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java (line 335) <https://reviews.apache.org/r/50404/#comment209208> Should this be Becoming standby instead? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java (line 339) <https://reviews.apache.org/r/50404/#comment209209> Fix the comment? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java (line 476) <https://reviews.apache.org/r/50404/#comment209210> @VisibleForTesting ? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java (line 77) <https://reviews.apache.org/r/50404/#comment209211> nit: not -> now - Sravya Tirukkovalur On July 25, 2016, 6:43 p.m., Rahul Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50404/ > ----------------------------------------------------------- > > (Updated July 25, 2016, 6:43 p.m.) > > > Review request for sentry, Anne Yu and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1415: Provide a hook to stop the active sentry sevice > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/Activator.java > 730dbb1b6e290c54ad60a5074009fad778d7b77c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/LeaderStatus.java > e32e1db5bbb92d35ad4063e9410c583231743edf > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 51dde0e5fcfb9dd93a47351efa3a78692bb60202 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/50404/diff/ > > > Testing > ------- > > > Thanks, > > Rahul Sharma > >
