----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50182/#review144165 -----------------------------------------------------------
Seems like we need to not block Sentry startup for the sake of HMS full update (to avoid dependencies at startup), but would like to not serve requests ( eventually only for Hive requests) until the full update processing is finished? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (line 234) <https://reviews.apache.org/r/50182/#comment210185> Seems like we should make a synchronized call to createIntialUpdate anyways as the calling thread needs to block? In which case, is there a reason why we want to sppin up another thread? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (lines 257 - 266) <https://reviews.apache.org/r/50182/#comment210186> Seems like we should never apply deltas unless full update processing is completed? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java (lines 269 - 272) <https://reviews.apache.org/r/50182/#comment210182> Seems like this needs to be implemented partially in this patch? That is, use fullUpdateComplete? Eventually we should set this value based on notification id stored in Sentry? - Sravya Tirukkovalur On July 29, 2016, 1:34 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50182/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 1:34 a.m.) > > > Review request for sentry, Anne Yu and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Added logic in HMSFollower for hive full update. > Block sentry service from start up until full update fetch is complete. > Fetch notification logs which are before failover but did not applied. > > > Diffs > ----- > > sentry-hdfs/sentry-hdfs-common/pom.xml > e767e06c13be2312ccd04e39c518ddef4fbf7744 > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/FullUpdateInitializer.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestFullUpdateInitializer.java > PRE-CREATION > sentry-provider/sentry-provider-db/pom.xml > b8143ffa3adca9e47e7cb092131d65064d57c86b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > e93e5b45caa1db61d6c5d69312f66f475dd02ee8 > > Diff: https://reviews.apache.org/r/50182/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
