----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51168/#review146060 -----------------------------------------------------------
Thank Colin, I left some comments. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java (line 125) <https://reviews.apache.org/r/51168/#comment212436> Since **SentryGenericServiceClientDefaultImpl** use the addr and port in conf, how about to update the configuration to create different client instance. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 146) <https://reviews.apache.org/r/51168/#comment212433> Must we change array to arraylist? new ArrayList<Endpoint>()? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java (line 149) <https://reviews.apache.org/r/51168/#comment212437> are all the constructors public? if yes, we could use getConstructor, and remove setAccessible(true). - Dapeng Sun On 八月 17, 2016, 1:12 p.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51168/ > ----------------------------------------------------------- > > (Updated 八月 17, 2016, 1:12 p.m.) > > > Review request for sentry, Dapeng Sun and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > We might be able to just use PoolClientInvocationHandler in > SentryGenericServiceClientFactory. This way, we get the StandbyException > handling needed for Sentry HA support for Generic model clients. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > ee6cdf7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientFactory.java > 980d930 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientPoolFactory.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java > 353d461 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 9e90af8 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientPoolFactory.java > 0164fa6 > > Diff: https://reviews.apache.org/r/51168/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
