----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51471/#review147047 -----------------------------------------------------------
Thanks for refactoring this Anne! It is a bit hard to review the improvements you made along with refactoring, as there is no diff of changes due to new files. Can you point us to the code changes that you made? - Sravya Tirukkovalur On Aug. 27, 2016, 12:13 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51471/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2016, 12:13 a.m.) > > > Review request for sentry, Hao Hao and Sravya Tirukkovalur. > > > Bugs: SENTRY-1429 and SENTRY-1455 > https://issues.apache.org/jira/browse/SENTRY-1429 > https://issues.apache.org/jira/browse/SENTRY-1455 > > > Repository: sentry > > > Description > ------- > > SENTRY-1429, SENTRY-1455: fix flaky TestHDFSIntegration, refactor this huge > test class, improve its cleanUp and setUp for temp HDFS dirs; divide test > class into smoke test class and p2 test class; in post commit run, we will > only run smoke tests. > > > Diffs > ----- > > pom.xml b53e7766749c75f8e36097f624fd7a812c6d1761 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > b0a3b6edc6201a9f902df1786f591b6bf3ac2250 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationAdvanced.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationEnd2End.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationWithHA.java > be6d0822ea56509ae9171d2b79026b1c952c2ec9 > > Diff: https://reviews.apache.org/r/51471/diff/ > > > Testing > ------- > > Local. > > > Thanks, > > Anne Yu > >
