----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52150/#review150040 -----------------------------------------------------------
Thanks a lot Li for taking this! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java <https://reviews.apache.org/r/52150/#comment217854> I think we may still want to keep the activator code, and just disable fencing in sentry store. So we can have a backup as active/passive model. - Hao Hao On Sept. 22, 2016, 5:27 a.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52150/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 5:27 a.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Keep the Fencer and Activator classes and disable fencing that brought by > SENTRY-1317 and SENTRY-1399, including some tests cases (e.g. TestActivator). > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 6f8239dcf2ae23962efe6bb0edf12d3c14e1a038 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > 39e55c3d9cb17ed498aaad98f1c490401c12030b > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > e2b92f919c8d4f2bb347ee70c5c623559d57002a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 894fcc966b511ccf309599fd10960f9a11ae8e96 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java > 353d461d84eb8438506e4bb209828feb98183fa7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 74977193760dd1958bdafaa3d6dac1ba27d81f32 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java > c52197f1ca514604a01ce4f4d9d7d35de30994a0 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java > fd10a7a23bcc21786323a27f36aba918f77e819c > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFencer.java > 42b67ba4078d998a069aa6600b1ab24011b7dd26 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 06342063965a0e6b295fbdbaf2dfc517a2045d60 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > 98f18314d387a831707ba5f06836ae41926878db > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryVersion.java > e401859ab492c1d2a7634361fa301b3350661929 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestActivator.java > 60cfc735832433fb4dbeae1c2d617dd713fc3f3e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestFailover.java > 57d579cc6179319e3525424d652d224323e21457 > > Diff: https://reviews.apache.org/r/52150/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
