> On Oct. 7, 2016, 12:56 a.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 77 > > <https://reviews.apache.org/r/52138/diff/6/?file=1525949#file1525949line77> > > > > Shall we name this as needHiveSnapshot instead, to be more descriptive? > > And add a comment why this is set to false?
Make sense, will change the name. > On Oct. 7, 2016, 12:56 a.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java, > > line 206 > > <https://reviews.apache.org/r/52138/diff/6/?file=1525949#file1525949line206> > > > > I think there are two different requirements here > > 1. We will need to get Hive snapshot if the Notification ID we are > > requesting has been rolled over in the NotificationLog table of Hive. > > 2. If we decide to store the current HMS snapshot in memory in Sentry > > deamon - At sentry deamon restart, we should load the full state from > > Sentry DB if it exists. > > These two are very different and should be handled separately. It feels > > like we are confusing between two cases here. Yeah, actaully we only store the current HMS snapshot in Sentry DB, so will change the TODO accordingly. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52138/#review151744 ----------------------------------------------------------- On Oct. 6, 2016, 10:22 p.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52138/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 10:22 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Li Li, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1463: Ensure HMS point-in-time snapshot consistency > > The implemented logic is: > 1. Read current HMS notification ID_initial > 2. Read HMS metadata state > 3. Read current notification ID_new > 4. If ID_initial != ID_new then discard the current state and goto 1. > > Use configurable property: sentry.hms.snapshot.retries.max.count for max > number of retry. > > Change-Id: I7590076b875bd97b2fb340008926ea5995896d72 > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > 89892924839df8058ea82e7819973d576420f578 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 9e9358b8bdcfb4177d0320da26739d990d287f09 > > Diff: https://reviews.apache.org/r/52138/diff/ > > > Testing > ------- > > > Thanks, > > Hao Hao > >
