> On Oct. 25, 2016, 9:07 p.m., Anne Yu wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java, > > line 35 > > <https://reviews.apache.org/r/53175/diff/1/?file=1545318#file1545318line35> > > > > This is very nice. Maybe we can make e2e tests use pool based clients > > by default. > > Li Li wrote: > Now we want to use the original model - non pool model which is used by > current sentry clients (e.g. impala), so our e2e tests should focused in non > pool as well.
OIC. Thanks for clarification. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53175/#review153822 ----------------------------------------------------------- On Oct. 25, 2016, 8:20 p.m., Li Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53175/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 8:20 p.m.) > > > Review request for sentry, Alexander Kolbasov, Anne Yu, Hao Hao, Lenni Kuff, > and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Currently sentry clients e.g. impala uses non pool model > (SentryPolicyServiceClientDefaultImpl), thus it's better to keep the non pool > model for those clients to avoid unnecessary incompatible issues. > Also the current pool model (PoolClientInvocationHandler) does not manage the > opening connections very well. e.g. Opening connections with failed servers > should be closed promptly. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 9e90af8f5b638d346e3f48405441ad97b9ef09ad > > Diff: https://reviews.apache.org/r/53175/diff/ > > > Testing > ------- > > > Thanks, > > Li Li > >
