> On Nov. 3, 2016, 9:59 p.m., Hao Hao wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java, > > line 88 > > <https://reviews.apache.org/r/52916/diff/3/?file=1552764#file1552764line88> > > > > Make it void here since we are not returning anything? Same thing for > > the rest of APIs. > > Alexander Kolbasov wrote: > I had to do it this way because of the way Mockito works - it needs an > object returned. This only affects testig path, not normal code. > > Li Li wrote: > Nit: you can use > doThrow(SomeException).when(mockedObject).methodReturningVoid(...); instead > of when(mockedObject.methodReturningObject(...)).thenThrow(someException) to > handle the returning void method in Mockito. > > e.g. void createRole(): > doThrow(new SentryAlreadyExistsException("Role: " + roleName + " already > exists")).when(mockStore).createRole(Matchers.anyString(), roleName, > Matchers.anyString()); > > We can create a followup jira for it.
Yes, will create follow up jira. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52916/#review154821 ----------------------------------------------------------- On Nov. 3, 2016, 3:58 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52916/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 3:58 a.m.) > > > Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, Li Li, and > Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-1505 CommitContext isn't used by anything and should be removed > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > f09004226124d3c2290abf7e36bc09b46afb8223 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > 687a7e0443a6c47cbf39f9eaff7e796636963970 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java > e0a5f03d5cc72dadbd0325efd7e9734a4bf48558 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java > 1d9c246214e50cea08b8c69df9a1c6a3080346ed > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > e59d12a6188d84d1a6bd627dd7776cefa0fbea44 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/CommitContext.java > c74dbf3be18c68aa8fdaca2ce12c24e7e8ae5a54 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 17113e62f54f4758e4c86bccbedfa6f57b830e4a > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/NotificationHandler.java > b1a4b7fb39af3db1181a125365da09655694c480 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/NotificationHandlerInvoker.java > 856ef9a6a830ab6829d55cfe45a8e7f15620b81b > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 5dff12a5026ebb6764e83baf90c7b12d069701fa > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java > 8b3599fd9cb4dd80700c6bf405d35db16a72e3d7 > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/thrift/TestNotificationHandlerInvoker.java > 6a2f48f39246efbb5d7e80b4562ea19240dfd8b6 > > Diff: https://reviews.apache.org/r/52916/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
