> On Nov. 28, 2016, 6:53 p.m., Hao Hao wrote: > > bin/run_sentry.sh, line 24 > > <https://reviews.apache.org/r/53872/diff/1/?file=1566622#file1566622line24> > > > > Should it be configurable?
Configurable in what way? I don't want this script to have any argument since all of them are going to the executable. On the other hand this is checked in a specific branch, so this can be always made branch-specific. I can try to detect this, but it would be error-prone. > On Nov. 28, 2016, 6:53 p.m., Hao Hao wrote: > > bin/run_sentry.sh, line 34 > > <https://reviews.apache.org/r/53872/diff/1/?file=1566622#file1566622line34> > > > > If mvn is not installed, ask to install and then run? This is a script for developers, not end users, if they don't have mvn they are not able to compile it in the first place (and this requires mvn install first). - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53872/#review157096 ----------------------------------------------------------- On Dec. 3, 2016, 5 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53872/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 5 a.m.) > > > Review request for sentry, Colm O hEigeartaigh, Colin Ma, Hao Hao, kalyan > kumar kalvagadda, Vamsee Yarlagadda, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > SENTRY-1525: Provide script to run Sentry directly from the repo > > > Diffs > ----- > > bin/run_sentry.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/53872/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
