----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54464/ -----------------------------------------------------------
(Updated Dec. 8, 2016, 7:44 a.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar kalvagadda. Changes ------- Addressed Kalyan and Sasha's comments. Repository: sentry Description ------- This change will ensure that multiple calls to the DB are replaced with a single call that looks for multiple matching values. More reference: Checkout "Collections" section under http://etutorials.org/Programming/Java+data+objects/Chapter+9.+The+JDO+Query+Language/9.6+The+Query+Filter/ Diffs (updated) ----- sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java f773a4443e81c5cde3aca0056a2e33d528bf4ec9 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 64df6a5655cf2c121cb44f2274369fbe9d70ec83 Diff: https://reviews.apache.org/r/54464/diff/ Testing ------- Verified the changes by running the unit tests of TestSentryStore and all 40 tests passed. ```bash vamsee-MBP:sentry-service-server vamsee$ mvn clean test -Dtest=TestSentryStore ... ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.sentry.provider.db.service.persistent.TestSentryStore 2016-12-06 18:30:07.974 java[5930:877254] Unable to load realm info from SCDynamicStore Tests run: 40, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 16.984 sec - in org.apache.sentry.provider.db.service.persistent.TestSentryStore Results : Tests run: 40, Failures: 0, Errors: 0, Skipped: 2 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 38.016s [INFO] Finished at: Tue Dec 06 18:30:24 PST 2016 [INFO] Final Memory: 59M/660M [INFO] ------------------------------------------------------------------------ ``` Thanks, Vamsee Yarlagadda
