> On Dec. 13, 2016, 5:58 p.m., Alexander Kolbasov wrote: > > The change is fine, but the original JIRA was about the fact that we call > > split twice where we can split just once and save the result. The first > > time we split for the if statement, the second - to return the result. > > Jan Hentschel wrote: > Ok, good to know. Wasn't sure about that. Should I change the patch to > the way you mentioned?
That would be great since you are touching this code anyway. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54697/#review159031 ----------------------------------------------------------- On Dec. 13, 2016, 9:55 a.m., Jan Hentschel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54697/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 9:55 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-1513 > https://issues.apache.org/jira/browse/SENTRY-1513 > > > Repository: sentry > > > Description > ------- > > Changed the way the split works when parsing a path and corrected spelling in > PathsUpdate > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 7cfb3bf > > Diff: https://reviews.apache.org/r/54697/diff/ > > > Testing > ------- > > > Thanks, > > Jan Hentschel > >
