----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54798/#review161952 -----------------------------------------------------------
I would consider unifying error messages from SentryNoSuchObjectException and SentryAlreadyExistsException using their constructors rather then relying on consumers to produce uniiform error messages. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 236) <https://reviews.apache.org/r/54798/#comment233222> Do we ened to construct the msg with your changes? The exception will have the message. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java (line 238) <https://reviews.apache.org/r/54798/#comment233223> Should we do something similar for SentryNoSuchObjectException? - Alexander Kolbasov On Jan. 17, 2017, 7:34 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54798/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 7:34 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, > and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > Added code changes to SentryStore to have proper message (where the > exceptions are originated). If this is done we can avoid decorating them > later. > I saw issue with exceptions created while role create/drop and made required > changes. > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > b7ae63430cddb81cb3235a7b04ecf95410d8604f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 898632ddef6ac5eec7b0e240c596f57f427fda9d > > Diff: https://reviews.apache.org/r/54798/diff/ > > > Testing > ------- > > I have performed tests using Sentrytool Client. > > > Thanks, > > kalyan kumar kalvagadda > >
