-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55735/#review162377
-----------------------------------------------------------


Fix it, then Ship it!




The fix is fine, but longer term we should resync this synchronization.


sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
 (line 80)
<https://reviews.apache.org/r/55735/#comment233732>

    How would tests control whether enableNotificationLog is on or off?


- Alexander Kolbasov


On Jan. 19, 2017, 11:28 p.m., Hao Hao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55735/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 11:28 p.m.)
> 
> 
> Review request for sentry.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-1596: Hive tests failing for sentry-ha-redesign branch
> 
> Change-Id: If4896f1594b214e4022d99fa0fcf2f18ec0f39d3
> 
> 
> Diffs
> -----
> 
>   
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
>  69fc8d2d1d2a6dd49c8f540b3439ce0732dd54fc 
> 
> Diff: https://reviews.apache.org/r/55735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hao Hao
> 
>

Reply via email to