-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55999/
-----------------------------------------------------------

(Updated Feb. 4, 2017, 5:42 a.m.)


Review request for sentry, Alexander Kolbasov and Hao Hao.


Changes
-------

o + Shasha's + Hao's comments.


Bugs: SENTRY-1602
    https://issues.apache.org/jira/browse/SENTRY-1602


Repository: sentry


Description
-------

SENTRY-1602 Code cleanup for Sentry JSON message factory for hive notifications


Diffs (updated)
-----

  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterPartitionMessage.java
 890186ba7eecd4aace280d9a1b56a8f01b625b77 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/JSONAlterTableMessage.java
 76211c35f4f5ed158b5c3052f7288cd0083f0d52 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java
 c0c469c1b1bfcd09494bb611a4a07911f5ef3192 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java
 99eb67a61363616af663a9be579b2e3a3344fd69 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java
 6e59e2568c8fb3526cd7a8ce29b08f5d8f5b0d62 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java
 ba19cbe42a242ea74f3ea9bf424e799e95d17b3f 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java
 57d11d22f2f7c099c8dd354a207dbb297e39be3f 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java
 05f83f7effee07204e7b0597ac6faf1e0e2e6cdf 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java
 2ab61f7ad5d30a1edb454c3cb239532c736b52e6 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java
 7005776425a65ab5fdb4b959391c3558000406f4 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java
 b645c4504ce6e768b31e6f7a1a39b60f73e1ac64 
  
sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java
 00e7db8ea4ccf92dae58869fcb21e6e2fcb27103 
  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java
 f3cefd6a232bfb91db28f04bebcc98ab3c1ca658 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java
 6f1886f942ca80ab4c356b81777d3ac336017292 

Diff: https://reviews.apache.org/r/55999/diff/


Testing
-------

Ran unit test cases and they passed.


Thanks,

Nachiket Vaidya

Reply via email to