----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56411/#review164577 -----------------------------------------------------------
sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java (line 210) <https://reviews.apache.org/r/56411/#comment236345> Is sending empty list better than sending null list for List<AccessURI>? Do we have test cases which exercise this path? Did those pass? - Nachiket Vaidya On Feb. 7, 2017, 10:49 p.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56411/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 10:49 p.m.) > > > Review request for sentry, Hao Hao, kalyan kumar kalvagadda, Nachiket Vaidya, > and Vamsee Yarlagadda. > > > Bugs: SENTRY-1624 > https://issues.apache.org/jira/browse/SENTRY-1624 > > > Repository: sentry > > > Description > ------- > > SENTRY-1624 DefaultSentryValidator doesn't correctly construct > SentryOnFailureHookContextImpl > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive-v2/src/main/java/org/apache/sentry/binding/hive/v2/authorizer/DefaultSentryValidator.java > c9da3ab0a901095acc0d78ce2ed0da0f0038ee56 > > Diff: https://reviews.apache.org/r/56411/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
