----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56356/#review164562 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java (line 280) <https://reviews.apache.org/r/56356/#comment236331> Are we sure that query.execute does not return null? sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2117) <https://reviews.apache.org/r/56356/#comment236451> mSentryRoles here is returned by qury.execute(). As per datanucleus documentation it can return null. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2139) <https://reviews.apache.org/r/56356/#comment236452> Ditto sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2196) <https://reviews.apache.org/r/56356/#comment236453> ditto sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2277) <https://reviews.apache.org/r/56356/#comment236454> query.execute can return null. - kalyan kumar kalvagadda On Feb. 7, 2017, 2:14 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56356/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 2:14 a.m.) > > > Review request for sentry, Misha Dmitriev, Hao Hao, kalyan kumar kalvagadda, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1615 > https://issues.apache.org/jira/browse/SENTRY-1615 > > > Repository: sentry > > > Description > ------- > > SENTRY-1615 SentryStore should not allocate empty objects that are > immediately returned > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 145808c04c1564eee624f3da2276852e26342c9f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 321c094366caa2b4a56758781e5fc5a2fc9218d0 > > Diff: https://reviews.apache.org/r/56356/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
