> On Feb. 8, 2017, 6:59 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java, > > line 232 > > <https://reviews.apache.org/r/56403/diff/1/?file=1626910#file1626910line232> > > > > Extra space?
which extra space? I see change from "part_col1" to partColName. > On Feb. 8, 2017, 6:59 p.m., Hao Hao wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java, > > line 356 > > <https://reviews.apache.org/r/56403/diff/1/?file=1626910#file1626910line356> > > > > Extra space? ditto. - Nachiket ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56403/#review164740 ----------------------------------------------------------- On Feb. 7, 2017, 8:54 p.m., Nachiket Vaidya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56403/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 8:54 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and Vamsee Yarlagadda. > > > Bugs: SENTRY-1387 > https://issues.apache.org/jira/browse/SENTRY-1387 > > > Repository: sentry > > > Description > ------- > > SENTRY-1387 Add HDFS sync tests for drop partition for external/implicit > locations > > makeMetastoreBasePartitionObject() assigns the table location in partition. > This is the root cause of this behavior. > There are two versions of makeMetastorePartitionObject() that call > makeMetastoreBasePartitionObject(). One sets given location and other keeps > the location unchanged (which is table location). > To fix this: set the partition location to null in > makeMetastoreBasePartitionObject(). It will auto-generated by Hive in the > format : <part_column>=<part_value>. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 567b4c86339a9494647dccc980df2b427225907f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java > 4d8889a27a303111507cc5a9b74a91ca7c5c1e63 > > Diff: https://reviews.apache.org/r/56403/diff/ > > > Testing > ------- > > o ran complete test cases of sentry > o modified unit test case. > > > Thanks, > > Nachiket Vaidya > >
