----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54947/ -----------------------------------------------------------
(Updated Feb. 16, 2017, 5:04 p.m.) Review request for sentry, Alexander Kolbasov, Hao Hao, Vamsee Yarlagadda, and Vadim Spector. Changes ------- Added changes to address review comments and fixed some other issues identified Repository: sentry Description ------- SENTRY-1556 Simplify privilege cleaning I made changes for the first approach by removing privileges moment they are not associated to any role. I have identified below scenarios which this will happen When a role is deleted, we can see if the associated privileges are associated to any other roles. All the privileges that are not associated to any roles can be deleted from storage When a privilege is revoked for a role, we can remove the privilege from storage if it is not associated to any role Note: Once this approached is reviewed and accepted, we need not call PrivCleaner periodically for cleanup Diffs (updated) ----- sentry-service/sentry-service-common/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java f9fb0f32de23cfdc1bda3636d20a0e24d66cc1c6 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java 57b6effa1b1bbfa22fbc2114db1e502365343207 sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 6dc6918314a11e343be281e86ecfa16ec4cf895a sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java b7ae63430cddb81cb3235a7b04ecf95410d8604f sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryPrivilege.java PRE-CREATION sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java 29134fec58e479e79aefb6cf96c6261698d64c08 sentry-service/sentry-service-server/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 17a4a937221891a72ee44db92976cfa5cab40bc4 Diff: https://reviews.apache.org/r/54947/diff/ Testing ------- Added unit tests the scenarios mentioned in description. Also tested the same with Sentry thrift client. Run unit test cases of TestSentryStore. Thanks, kalyan kumar kalvagadda
