> On Feb. 22, 2017, 1:13 a.m., Hao Hao wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > > Lines 254 (patched) > > <https://reviews.apache.org/r/56709/diff/1/?file=1634523#file1634523line254> > > > > update the character and collation as well. e.g. `PERM_CHANGE` > > VARCHAR(4000) CHARACTER SET utf8 COLLATE utf8_bin NOT NULL > > kalyan kumar kalvagadda wrote: > There are certain tables like MAUTHZPATHSMAPPING_PATHS amd > AUTHZ_PATHS_MAPPING, where this is not followed. I feel, it should be > addressed as well. Please confirm > > Hao Hao wrote: > Yes, could you please also add it at those places as well > > kalyan kumar kalvagadda wrote: > Changing charset and collate for column AUTHZ_OBJ_NAME in table > AUTHZ_PATHS_MAPPING is causing issue. With this charset and collate size of > the column is going beyond 767 bytes. Innodb, MySQL Engines limits key size > to 767 bytes. As a result we can not have index on AUTHZ_OBJ_NAME. AS the > schema of table AUTHZ_PATHS_MAPPING is changing, we better handle it as part > of that. I will revert the changes done for MAUTHZPATHSMAPPING_PATHS amd > AUTHZ_PATHS_MAPPING.
Thanks a lot for the confirmation Kalyan, LGTM. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56709/#review166277 ----------------------------------------------------------- On March 1, 2017, 11:16 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56709/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 11:16 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, Mat Crocker, Vamsee > Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1569 > https://issues.apache.org/jira/browse/SENTRY-1569 > > > Repository: sentry > > > Description > ------- > > SENTRY-1569 Added changes to sql scripts persist Perm/Path change Adding > missing files > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/007-SENTRY-1365.mysql.sql > 1829e2f > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/008-SENTRY-1569.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.8.0.sql > 0606116 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.8.0.sql > be9a33e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.8.0.sql > 1c8848c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.8.0.sql > fc7b53f > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.8.0.sql > ce807a5 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.7.0-to-1.8.0.sql > 3657377 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.7.0-to-1.8.0.sql > 5d88887 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.7.0-to-1.8.0.sql > b6108e7 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.7.0-to-1.8.0.sql > d5b7d6e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.7.0-to-1.8.0.sql > f0c8cfb > > > Diff: https://reviews.apache.org/r/56709/diff/4/ > > > Testing > ------- > > Tested the scrips against db2, postgres, musql, oracle and derby databases. > > Also ran SchemaToll test for deby. > > > Thanks, > > kalyan kumar kalvagadda > >
