----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57308/#review167913 -----------------------------------------------------------
Fix it, then Ship it! Ship It! bin/sentry Lines 78 (patched) <https://reviews.apache.org/r/57308/#comment239881> Do you need to check that HIVE_CONF_DIR is set? Something like [[ -n $HIVE_CONF_DIR ]] && HADOOP_CLASSPATH+=":${HIVE_CONF_DIR}" - Alexander Kolbasov On March 3, 2017, 10:41 p.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57308/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 10:41 p.m.) > > > Review request for sentry, Alexander Kolbasov, Hao Hao, and kalyan kumar > kalvagadda. > > > Repository: sentry > > > Description > ------- > > Hive client jars will automatically be put under the classpath of Sentry > process by Maven. For hive-conf, one has to set a standard environmental > variable for defining Hive client configs - HIVE_CONF_DIR. In order for > sentry to pick this up, this patch will make sentry scripts be aware of this > variable. > > > Diffs > ----- > > bin/sentry 93809eaa1beb617d6977966e4ffa1d1262e8d3d9 > > > Diff: https://reviews.apache.org/r/57308/diff/1/ > > > Testing > ------- > > Tested on the cluster before and after the patch and verified the client > configs are being passed correctly in a way that HiveConf instantiation is > automatically picking up. > > (Screenshot attached) > > > File Attachments > ---------------- > > Configs being picked up > > https://reviews.apache.org/media/uploaded/files/2017/03/03/34145b57-cb71-4816-aa8d-3b669f90ec87__Screen_Shot_2017-03-04_at_4.09.56_AM.png > > > Thanks, > > Vamsee Yarlagadda > >
